Repository navigation
build(webapi): upgrade to ReScript 13 alpha.7 [Codex] - #414
Merged
Merged
Conversation
jderochervlk
requested review from
brnrdog,
fhammerschmidt and
tsnobip
as code owners
November 16, 2026 21:04
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the compiler baseline before continuing the private-record migration in #404. ReScript 13.0.0-alpha.7 includes rescript-lang/rescript#9125, which rejects coercion from another type into a private record—the loophole reproduced on alpha.5 in #403.
Pin the development compiler and raise the minimum peer version to alpha.7, update the lockfile and installation guidance, and reject the former alpha.5 baseline in packed-consumer checks. Add a regression for forged Response coercion alongside positive coverage for native construction, direct field reads, outward coercion, and the existing File-to-Blob helper. This does not introduce package-wide native-record privacy.
The upgrade also requires a concrete typed-array operation in the ImageData fixture and support for the compiler's new documentation parameter/type schema. Preserve rendered signatures and type links, including callbacks, tuples, and generic parameters. The changes across 40 existing ReScript files are the new compiler's formatting output.
Alpha.7 no longer supports native compilation on Intel Macs (
darwin-x64); the migration notes and project status call out that compatibility break.Refs #403. This is the prerequisite branch for #404, not the private-record migration itself.