Repository navigation
Test pins against multiple Connect versions with with-connect - #365
mconflitti-pbc wants to merge 4 commits into
Conversation
|
planning to do the same thing on rstudio/pins-r |
nealrichardson
left a comment
There was a problem hiding this comment.
Thank you for doing this
| matrix: | ||
| python: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| os: ["ubuntu-latest"] | ||
| os: ["ubuntu-24.04"] |
There was a problem hiding this comment.
what if instead you kept this as ubuntu-latest? There is already a 3.9 test added to the matrix below so we have the basic coverage already.
| @@ -21,11 +21,11 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| python: ["3.9", "3.10", "3.11", "3.12", "3.13"] | |||
There was a problem hiding this comment.
Following the comment below: drop 3.9, add 3.14?
There was a problem hiding this comment.
Should we bump this and the one below to 3.14, or at least a non-EOL version?
There was a problem hiding this comment.
This is v7 now, might as well ask the agent to bump all of the actions while we're here
| fail-fast: false | ||
| matrix: | ||
| connect-version: | ||
| - "preview" |
There was a problem hiding this comment.
Same comment as on pins-r: this is great but I think we can dial it back a little and still have the coverage we need.
CI currently tests one Connect target and uses outdated actions and Python runtimes. Test eight Connect targets:
preview,release, six-month samples within the 18-month support window (2026.07.0,2026.01.1,2025.07.0), and one historical release per year (2024.06.0,2023.07.0,2022.10.0). October 2022 is the oldest target supported by with-connect's bootstrap authentication. Refresh the pinned targets as releases move through the support window; the aliases advance automatically.Use
ubuntu-latestfor the main Python 3.10–3.14 matrix, keep a dedicated Python 3.9 job on Ubuntu 24.04, and test Python 3.14 on macOS and Windows. Update pytest to the 8.4 line so tests collect on Python 3.14 while retaining Python 3.9 support.Refresh actions throughout the repository, including the Google Cloud auth/setup migration and deployment/artifact actions. Pin with-connect to the shared revision used by rsconnect-python and pins-r. API-key setup falls back to the legacy Connect endpoint only on HTTP 404, and failed setup stops the test command immediately. Keep fail-fast disabled and use the existing CONNECT_LICENSE secret.
Validation: 144 local Python 3.14 tests passed both serially and with CI's four-worker options (4 skipped, 1 expected failure), including eight API-key regression cases. Ruff, actionlint's workflow/action checks, independent review, and git diff checks passed. Existing shellcheck warnings remain outside the changed Connect job. Cloud and Connect integration results run in this PR's CI.