Repository navigation
Keep the session alive when evaluated code raises Interrupt - #1279
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When code evaluated in IRB raises
Interrupt(for exampleraise Interrupt, or a library that restored the default INT handler), IRB exits instead of printing the exception and returning to the prompt:still_aliveis never printed.Cause: in
Irb#eval_input,Interruptis a subclass ofSignalException, sorescue SystemExit, SignalExceptionre-raises it before the laterrescue Interrupt, Exceptionclause can see it. Before 6269138 (#617) there was a separaterescue Interrupt => excahead of theSignalExceptionclause; that commit folded it into the last clause, which made theInterruptthere unreachable.Fix: restore a dedicated
rescue Interruptclause beforerescue SystemExit, SignalException, handled the same way as other exceptions. Ctrl-C is unaffected since it goes through the SIGINT trap.Test: added
test_raise_interrupt_does_not_exit_irbto test/irb/test_raise_exception.rb. It fails on master (the irb process is killed by SIGINT) and passes with this change.bundle exec rake testandbundle exec rubocoppass.Found with rbcop, RuboCop reimplemented in Rust.