Repository navigation
Conversation
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 3 files with indirect coverage changes @@ Coverage Diff @@
## development/9.6 #6358 +/- ##
===================================================
+ Coverage 90.76% 90.82% +0.05%
===================================================
Files 207 207
Lines 39016 39046 +30
===================================================
+ Hits 35413 35463 +50
+ Misses 3603 3583 -20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| "@opentelemetry/instrumentation-ioredis": "~0.70.0", | ||
| "@opentelemetry/instrumentation-mongodb": "~0.75.0", | ||
| "@scality/arsenal": "^8.6.1", | ||
| "@scality/arsenal": "git+https://github.com/scality/Arsenal#574ed2041c4a963e0c30a73e64c21d3807e5c0c9", |
There was a problem hiding this comment.
Arsenal is pinned to a raw commit (574ed204…) instead of a release tag. Git-based deps must pin to a tag. Release the Arsenal change (8.6.3?) and pin to that version before merging.
Temporary, until arsenal 8.6.4 is released. httpagent 1.1.1 is resolved as the tarball arsenal's own lockfile uses: installing arsenal from git builds it with its lockfile in the same yarn cache, and a git resolution here makes yarn reject that cache entry.
Set by requestTimeoutMs on a kmip or aws_kms entry, 5000 ms by default.
The KMIP functional job gets a KMS that accepts connections and never answers.
9917afd to
f217abc
Compare
nicolas2bert
left a comment
There was a problem hiding this comment.
LGTM
On follow up caught by Claude:
The AWS SDK's requestTimeout counts from the start of the request until the response headers arrive, and then it stops. Once the headers are in, nothing limits reading the body.
So this case still hangs forever:
- The KMS (or a proxy, or a network that drops packets) sends 200 OK and the headers.
- Then it sends nothing more.
- The S3 request waits forever, just like before the PR.
I created a follow up ticket ARSN-684 |
KMIP and AWS KMS requests have no time limit: a request to a KMS that doesn't respond keeps its caller waiting indefinitely.
This PR adds a timeout to each attempt to a
kmiporaws_kmsKMS.A request over the limit fails with a 500 error.