Repository navigation
CLDSRV-1008 return object lock state even if bucket is not lock-enabled - #6386
Conversation
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.6 #6386 +/- ##
===================================================
+ Coverage 90.84% 90.86% +0.01%
===================================================
Files 208 208
Lines 39275 39278 +3
===================================================
+ Hits 35679 35689 +10
+ Misses 3596 3589 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
d7dafa0 to
005068e
Compare
GetObjectRetention and GetObjectLegalHold errored out whenever the bucket was not lock-enabled, even when the object actually carried lock information, while GET/HEAD already exposed it through the x-amz-object-lock-* headers. On a DR site, the replicated lock state is enforced from object metadata while the bucket is deliberately not lock-enabled, and backup clients still need to read it. So return whatever is set on the object; when nothing is set, keep the existing errors. Issue: CLDSRV-1008
005068e to
de228d4
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue CLDSRV-1008. Goodbye francoisferrand. The following options are set: approve |
GetObjectRetention and GetObjectLegalHold used to fail as soon as the bucket was not lock-enabled, even if the object actually had lock information. Meanwhile GET/HEAD already return it through the
x-amz-object-lock-*headers, so the two views disagreed.This matters on DR sites: the replicated lock state is enforced from object metadata, but the DR bucket is deliberately not lock-enabled, and backup clients still need to read that state.
So now, whatever is set on the object gets returned: its retention, or its legal hold (ON or OFF). When nothing is set, the existing
InvalidRequeston a non-lock bucket is unchanged.Issue: CLDSRV-1008