Repository navigation
agent: retry a busy commit without repeating the transaction - #2084
Open
evgeny-simplex wants to merge 7 commits into
Open
evgeny-simplex wants to merge 7 commits into
evgeny-simplex wants to merge 7 commits into
Conversation
epoberezkin
marked this pull request as ready for review
November 19, 2026 21:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A COMMIT that waited more than the 100 ms busy timeout for another reader failed with SQLITE_BUSY and left the transaction open (sqlite-simple's
withImmediateTransactionrolls back only when the action fails).dbBusyLoopthen retried the whole transaction, BEGIN IMMEDIATE failed with "cannot start a transaction within a transaction", which is not retried, and every later transaction on the store's single connection failed the same way until restart: messages stopped in both directions. A COMMIT that failed on a deferred foreign key left the store stuck in the same way.withTransactionPriorityruns its own BEGIN IMMEDIATE, the action and COMMIT, in twodbBusyLoops. BUSY in BEGIN or in the action re-runs both, as before. A busy COMMIT is retried inside the open transaction, so the action runs once. Any failure of the COMMIT retries, including an exhausted budget, rolls back and rethrows, so the connection does not stay inside a transaction.