Skip to content

ci: open a pull request when the agent skills update - #78

Open
mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-gh-workflow-agent-skills
Open

mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-gh-workflow-agent-skills

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Summary

This pull request keeps the pre-installed agent skills current for developers who build from this sample, so their coding agent follows the latest Slack guidance without anyone running npx skills update by hand.

  • A daily workflow runs npx skills@1 update --project --yes in each folder with a skills-lock.json (3 in this repository) and opens one chore: update agent skills pull request when the skills change.
  • The workflow commits only .agents/skills, .claude/skills, and skills-lock.json, because skills also writes .grok/ and .kiro/ folders on update.
  • A README line explains the repository setting that lets the workflow open pull requests in an app created from this sample.

Testing

  • After merge, run Update agent skills from the Actions tab and confirm it opens one pull request that updates the skills in every folder.
  • Run it again and confirm it leaves that pull request unchanged.

Notes

@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality github_actions Pull requests that update GitHub Actions code labels Nov 18, 2026
@mwbrooks mwbrooks self-assigned this Nov 18, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review November 18, 2026 23:16
@mwbrooks
mwbrooks requested a review from a team as a code owner November 18, 2026 23:16

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 @mwbrooks LGTM! Neat that one workflow keeps the skills current for each app here 🎁

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 @mwbrooks thanks! Looping over all three implementation folders and staging only the skill paths keeps the update PR tidy; locally it staged exactly the 33 changed files.
Two blocking comments: the update PRs can't get their required checks, and the floating skills@1 runs with write access. 🙏

git commit -m "chore: update agent skills"
git push --force origin agent-skills
if [ "$(gh pr view agent-skills --json state --jq .state 2>/dev/null)" != "OPEN" ]; then
gh pr create --head agent-skills --title "chore: update agent skills" --body "Updates the agent skills in \`skills-lock.json\` to the latest versions."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ issue (blocking): main here requires the six lint and test checks from CI, but a PR opened with the default GITHUB_TOKEN never triggers ci.yml. Each update PR would wait on them until someone re-triggers it. Could we use an app token from actions/create-github-app-token for the push and gh pr create?

- name: Update the skills in each skills-lock.json
run: |
while IFS= read -r lock; do
(cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦 issue (blocking): skills@1 floats to every new 1.x and runs in a job that can write. A bad release could drop a .git/hooks file or a $GITHUB_PATH shim that the next step runs with GH_TOKEN. Could we pin an exact version, like skills@1.9.0?

Suggested change
(cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes)
(cd "$(dirname "$lock")" && npx --yes skills@1.9.0 update --project --yes)

steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 praise: persist-credentials: false with GH_TOKEN only on the push step keeps the token away from the update step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants