Repository navigation
Conversation
WilliamBergamin
left a comment
There was a problem hiding this comment.
💯 @mwbrooks thanks! Looping over all three implementation folders and staging only the skill paths keeps the update PR tidy; locally it staged exactly the 33 changed files.
Two blocking comments: the update PRs can't get their required checks, and the floating skills@1 runs with write access. 🙏
| git commit -m "chore: update agent skills" | ||
| git push --force origin agent-skills | ||
| if [ "$(gh pr view agent-skills --json state --jq .state 2>/dev/null)" != "OPEN" ]; then | ||
| gh pr create --head agent-skills --title "chore: update agent skills" --body "Updates the agent skills in \`skills-lock.json\` to the latest versions." |
There was a problem hiding this comment.
✅ issue (blocking): main here requires the six lint and test checks from CI, but a PR opened with the default GITHUB_TOKEN never triggers ci.yml. Each update PR would wait on them until someone re-triggers it. Could we use an app token from actions/create-github-app-token for the push and gh pr create?
| - name: Update the skills in each skills-lock.json | ||
| run: | | ||
| while IFS= read -r lock; do | ||
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) |
There was a problem hiding this comment.
📦 issue (blocking): skills@1 floats to every new 1.x and runs in a job that can write. A bad release could drop a .git/hooks file or a $GITHUB_PATH shim that the next step runs with GH_TOKEN. Could we pin an exact version, like skills@1.9.0?
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) | |
| (cd "$(dirname "$lock")" && npx --yes skills@1.9.0 update --project --yes) |
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
💯 praise: persist-credentials: false with GH_TOKEN only on the push step keeps the token away from the update step.
Summary
This pull request keeps the pre-installed agent skills current for developers who build from this sample, so their coding agent follows the latest Slack guidance without anyone running
npx skills updateby hand.npx skills@1 update --project --yesin each folder with askills-lock.json(3 in this repository) and opens onechore: update agent skillspull request when the skills change..agents/skills,.claude/skills, andskills-lock.json, becauseskillsalso writes.grok/and.kiro/folders on update.Testing
Notes
mainofslackapi/slack-skills-plugin, the same asnpx skills update.