Repository navigation
feat: add assistant.search.context and assistant.search.info methods - #1594
Conversation
|
Thanks for the contribution! Before we can merge this, we need @Cr1stal to sign the Salesforce Inc. Contributor License Agreement. |
44a3337 to
d3c35f8
Compare
d3c35f8 to
4b359dc
Compare
4b359dc to
36ec916
Compare
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
# Conflicts: # slack-api-client/src/test/java/test_locally/api/MethodsTest.java # slack-api-client/src/test/java/test_locally/api/methods/RequestFormBuilderTest.java # slack-api-client/src/test/java/test_locally/sample_json_generation/MethodsResponseDumpTest.java
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
left a comment
There was a problem hiding this comment.
☕ @Cr1stal Thanks so much for adding these, and for your patience on a review! Every documented argument is here, and the methods land in sorted order everywhere a method is listed. 👁️🗨️ A live call showed a few more fields in the assistant.search.context results than the docs example, and a different users shape, so I pushed a change to match those. 🪓 I also removed keywords_clauses, since the docs Arguments list doesn't include it and the API ignores it. 🧪 A test_with_remote_apis test for both methods now checks these against a live response, and 📝 main is merged in to resolve the test file conflicts.
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
============================================
+ Coverage 73.82% 73.90% +0.08%
- Complexity 4782 4796 +14
============================================
Files 489 489
Lines 14920 14959 +39
Branches 1559 1562 +3
============================================
+ Hits 11015 11056 +41
Misses 2978 2978
+ Partials 927 925 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Summary
Adds Java SDK support for the Slack Web API
assistant.search.*methods:assistant.search.contextassistant.search.infoThis includes request/response types, sync and async
MethodsClientsupport, form serialization, rate-limit metadata, mock JSON fixtures, and local tests.The
assistant.search.contextsample includes representative message, file, channel, and user result objects so downstream generated response types can infer concrete result shapes.Related to slackapi/node-slack-sdk#2607.
Category (place an
xin each of the[ ])Testing
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.