Skip to content

feat: add assistant.search.context and assistant.search.info methods - #1594

Merged
zimeg merged 6 commits into
slackapi:mainfrom
Cr1stal:feat/assistant-search-apis
Nov 19, 2026
Merged

zimeg merged 6 commits into
slackapi:mainfrom
Cr1stal:feat/assistant-search-apis

Conversation

@Cr1stal

@Cr1stal Cr1stal commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds Java SDK support for the Slack Web API assistant.search.* methods:

  • assistant.search.context
  • assistant.search.info

This includes request/response types, sync and async MethodsClient support, form serialization, rate-limit metadata, mock JSON fixtures, and local tests.

The assistant.search.context sample includes representative message, file, channel, and user result objects so downstream generated response types can infer concrete result shapes.

Related to slackapi/node-slack-sdk#2607.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Testing

./mvnw -pl slack-api-client -Dtest=test_locally.api.methods.AssistantTest test
./mvnw -pl slack-api-client -Dtest=test_locally.api.MethodsTest,test_locally.sample_json_generation.MethodsResponseDumpTest,test_locally.api.methods.RequestFormBuilderTest test
./mvnw -pl slack-api-client -Dtest=test_locally.sample_json_generation.MethodsResponseDumpTest#assistant_search test
git diff --check

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @Cr1stal to sign the Salesforce Inc. Contributor License Agreement.

@Cr1stal
Cr1stal force-pushed the feat/assistant-search-apis branch 4 times, most recently from 44a3337 to d3c35f8 Compare May 30, 2026 12:21
@Cr1stal
Cr1stal marked this pull request as ready for review May 30, 2026 12:25
@Cr1stal
Cr1stal requested a review from a team as a code owner May 30, 2026 12:25
@Cr1stal
Cr1stal force-pushed the feat/assistant-search-apis branch from d3c35f8 to 4b359dc Compare May 30, 2026 12:29
@Cr1stal
Cr1stal force-pushed the feat/assistant-search-apis branch from 4b359dc to 36ec916 Compare May 30, 2026 12:54
@zimeg zimeg added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Nov 18, 2026
@zimeg zimeg added this to the 1.55.1 milestone Nov 18, 2026
@zimeg zimeg changed the title Add assistant.search Web API methods feat: add assistant.search.context and assistant.search.info methods Nov 18, 2026
zimeg and others added 4 commits November 18, 2026 19:14
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
# Conflicts:
#	slack-api-client/src/test/java/test_locally/api/MethodsTest.java
#	slack-api-client/src/test/java/test_locally/api/methods/RequestFormBuilderTest.java
#	slack-api-client/src/test/java/test_locally/sample_json_generation/MethodsResponseDumpTest.java
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕ @Cr1stal Thanks so much for adding these, and for your patience on a review! Every documented argument is here, and the methods land in sorted order everywhere a method is listed. 👁️‍🗨️ A live call showed a few more fields in the assistant.search.context results than the docs example, and a different users shape, so I pushed a change to match those. 🪓 I also removed keywords_clauses, since the docs Arguments list doesn't include it and the API ignores it. 🧪 A test_with_remote_apis test for both methods now checks these against a live response, and 📝 main is merged in to resolve the test file conflicts.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.90%. Comparing base (ba1aa12) to head (f645c8a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1594      +/-   ##
============================================
+ Coverage     73.82%   73.90%   +0.08%     
- Complexity     4782     4796      +14     
============================================
  Files           489      489              
  Lines         14920    14959      +39     
  Branches       1559     1562       +3     
============================================
+ Hits          11015    11056      +41     
  Misses         2978     2978              
+ Partials        927      925       -2     
Flag Coverage Δ
jdk-14 73.90% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@zimeg
zimeg merged commit fa37703 into slackapi:main Nov 19, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants