Repository navigation
feat: add assistant.search.context method - #1667
Conversation
|
Thanks for the contribution! Before we can merge this, we need @ArielTM to sign the Salesforce Inc. Contributor License Agreement. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 84.65% 84.63% -0.02%
==========================================
Files 118 118
Lines 14080 14113 +33
==========================================
+ Hits 11919 11945 +26
- Misses 2161 2168 +7 ☔ View full report in Codecov by Harness. |
|
Hi @ArielTM thanks for you contribution 🚀 they are alway welcome Unfortunately we need to hold off on introducing these changes due to these APIs being in a limited access stage
We would also need unit tests for these changes 🙏 |
|
@WilliamBergamin Until this is in "limited access" , would you say the best way to use this api would be to do something like this instead ? |
|
@Pythonista7 Yess this is the recommended approach 💯 |
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
left a comment
There was a problem hiding this comment.
Hey @ArielTM! 👋 Thanks so much for sharing this with us, and for your patience while this method was in limited access. That's lifted now, so we'd love to bring this in! 📚 I pushed a change that matches the current reference: action_token is optional, the newer arguments are added in the order of the reference, and the docstring links to docs.slack.dev. 🧪 main is merged in too, and the coverage test now calls this method instead of skipping it. ✅ LGTM!
Summary
Add support for assistant.search.context . Although listed in docs, it is yet to be supported.
There's a discrepancy between https://api.slack.com/methods/assistant.search.context and https://api.slack.com/docs/apps/data-access-api#use-action-token on whether
action_tokenis required. From my testing it is so I set it as such. Lmk if that's not the case.Testing
Ran it using my app and workspace
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.