Repository navigation
fix(oauth): add async delete methods to the sqlite3 installation store - #2065
Merged
Merged
Conversation
SQLite3InstallationStore wraps every async method in its sync twin except async_delete_bot and async_delete_installation, so both (and async_delete_all, which calls them) raised NotImplementedError. An async Bolt app on this store failed on app_uninstalled and tokens_revoked and kept the tokens. Add the two wrappers, matching the file and amazon_s3 stores. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 84.60% 84.64% +0.03%
==========================================
Files 118 118
Lines 14067 14071 +4
==========================================
+ Hits 11901 11910 +9
+ Misses 2166 2161 -5 ☔ View full report in Codecov by Harness. |
mwbrooks
approved these changes
Nov 18, 2026
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Thanks @WilliamBergamin! Async Bolt apps on the sqlite3 store can finally clear their tokens on uninstall.
zimeg
approved these changes
Nov 18, 2026
zimeg
left a comment
Member
There was a problem hiding this comment.
✅ LGTM! Thanks for closing the async gap in the sqlite3 store @WilliamBergamin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds
async_delete_botandasync_delete_installationtoSQLite3InstallationStore, a follow-up suggested in review on #2062.NotImplementedError, and so didasync_delete_all, which calls them. An async Bolt app on this store failed onapp_uninstalledandtokens_revokedand kept the tokens.AsyncCacheableInstallationStoreover sqlite3 is fixed too, since it delegates to these methods.Testing
The new
test_async_deletefails onmainwithNotImplementedErrorand passes on this branch. It runs the three calls Bolt's async uninstall listeners make:async_delete_installation,async_delete_bot, andasync_delete_all.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code