Repository navigation
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 80.18% 80.19% +0.01%
==========================================
Files 244 245 +1
Lines 18736 18776 +40
==========================================
+ Hits 15024 15058 +34
- Misses 3712 3718 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cchensh
approved these changes
Nov 18, 2026
cchensh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Non-blocking nits for when this gets wired in:
readAutoUpdateResultreturns an error whenautoupdate.jsondoesn't parse. Since the next command reads it on startup, treating a corrupt or old-shape file as "no record" (and maybe clearing it) would keep a bad file from failing an unrelated command. A test for that case would help.- The temp file isn't fsynced before the rename, so after a power loss the record could be empty. Fine for a status file; a
Sync()beforeClose()would cover it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A, groundwork for the
auto-updateexperiment.Summary
This pull request adds a record of the result of a background CLI update, saved in its own file for the next command to report.
AutoUpdateResultholds the versions an update wentfromandto, plus anerrorwhen it failed.autoupdate.jsonin the Slack config directory, so it follows--config-dir. It stays out ofconfig.jsonbecause the background process would be a second process writing that file while other commands read it, andconfig.jsonwrites only lock within one process.auto-updateexperiment. Nothing calls these functions yet.Preview
N/A, nothing changes for developers yet.
Testing
N/A, nothing calls the record yet. The unit tests write and read back a record with and without an error, read a missing record as none, clear a record, and write under a custom
--config-dir.Notes
ClientFactoryand useclients.Fs, like the rest ofinternal/update. They're unexported since the code that reads and writes the record lives in this package too.Requirements
🤖 Generated with Claude Code