Repository navigation
docs: table rows need an explicit <tbody> under SSR - #1695
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
This is the docs half of solidjs/solid#4875. The code half is solidjs/solid#4895, which adds the dev warning
TABLE_ROWS_WITHOUT_TBODY.A
<table>whose rows come from a<For>or a row component has no<tr>in its own template. The compiler's malformed-HTML check therefore passes. In the browser, though, the HTML parser moves the server-rendered rows into a<tbody>it creates. After hydration the list cannot update those rows: removed rows stay on the page, and new rows are inserted after the<tbody>.guides/data-fetching-patterns: the paginated orders example now wraps its<For>in<tbody>. The old version showed the broken shape.guides/ssr-safe-code("Markup the browser rewrites"): adds table rows as the common case of nesting the compiler cannot see across components. It names the dev warning and gives an Avoid/Prefer pair.These pages are hand-written guides. The generated diagnostics reference page for the new code comes from
pnpm sync:diagnosticsonce solidjs/solid#4895 lands.This should merge together with solidjs/solid#4895, because the guide names a warning that PR adds.
Related issues & labels
Generated by Claude Code