Repository navigation
fix(configurator): retire failed S3 runners and enable production email - #284
Merged
Merged
Conversation
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
November 20, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two production gaps prevented normal use after v2.2.1: reported failed S3 workers could remain desired STARTED, keeping checkpoint inspection blocked, and production email had never been provisioned/bound.
Background maintenance now retires only source-verified runners of explicitly reported S3
apply_failedruns after a completion grace period. It verifies stopped tasks/processes before recording a scheduling timestamp; checkpoint and confirmation still recheck actual CF status. State, run recovery hold, locks and migrations remain intact. Timeouts, ambiguous failures, bootstrap/pending migration and separate recovery State stay excluded. Migration 101 adds only scheduling metadata/functions and an index.Add a separate reviewed Prod MailOut manifest, stage-isolated private bindings, asynchronous domain handling and strict DNS conflict protection. The production workflow requires the protected SMTP binding, passes it only to the application runtime and verifies the actual binding before SMTP checks. Existing branded templates and per-user topic preferences apply. The provider domain, DNS records and sender are active; uploading credentials to the protected GitHub environment is pending explicit approval required by automatic review. Credentials are never printed or committed.
Validation: full application check (2,180 tests passing, 100 skips including the separately executed database group); all 86 isolated PostgreSQL Plan/Apply cases; 19 CF stopped-runner tests; operator MailOut/production tests; workflow catalogue checks; bilingual operator/recovery documentation. Release notes for v2.2.2 are curated. No customer State was modified or run reconciled. Assistant knowledge/model behavior is unchanged; existing qualification limitations remain documented.