Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/configurator-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:

deploy:
needs: source
if: needs.source.result == 'success'
if: always() && !cancelled() && needs.source.result == 'success'
runs-on: ubuntu-latest
timeout-minutes: 100
environment:
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/generated/workflow-phases.de.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/diagrams/generated/workflow-phases.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions landing-zone-configurator/docs/production.de.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@ Die alten Modi sind nur für historische Nachweise erhalten: veröffentlichte
`accepted-assistant-limitations`-Releases bleiben kompatibel lesbar;
`dev-skip-assistant-qualification` bleibt Dev-only und nicht promotierbar.

Bei der Installation eines bestehenden Releases mit `publish=false` entfällt nur
die Veröffentlichung. Quellprüfung und geschützter Deploy-Job laufen weiterhin.
Prüfe, dass `deploy` einschließlich Laufzeitprüfungen tatsächlich erfolgreich
abgeschlossen wurde. Ein insgesamt grüner Workflow mit übersprungenem `deploy`
belegt keine Installation.

## Wiederherstellung und Rotation

Vorherige veröffentlichte Release-Assets und ihre geschützten Buildpack-Tags
Expand Down
5 changes: 5 additions & 0 deletions landing-zone-configurator/docs/production.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ remain only for historical provenance: published `accepted-assistant-limitations
releases remain readable; `dev-skip-assistant-qualification` stays Dev-only and
non-promotable.

Installing an existing release with `publish=false` skips publication only; source
verification and the protected deployment job still run. Confirm that the `deploy`
job actually completed successfully, including runtime checks. An overall green
workflow with `deploy` skipped does not prove installation.

## Recovery and rotation

Keep previous published release assets and their protected buildpack tags.
Expand Down
9 changes: 9 additions & 0 deletions landing-zone-configurator/infra/ci/production.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ function outputs(){
const values=Object.fromEntries(runtimeKeys.map(key=>[key,`synthetic-${key}`]));
return [{cf_runtime:{value:cf},plan_runner_cf:{value:runner},database_migration:{value:{host:values.LZC_DATABASE_HOST,port:values.LZC_DATABASE_PORT,database:"configurator",username:"configurator_migration",password:"migration-only"}},assistant_test_model_serving_token:{value:"test-token-never-publish"}}, {space:{value:{id,name:"configurator"}},runner_space:{value:{id:runnerId,name:"plans",org_id:runnerId}},app_environment:{value:{...values,LZC_SERVICE_ACCOUNT_KEY:"no"}},release_credentials:{value:{username:"app-space-deployer",password:"app-space-only"}},dispatcher_credentials:{value:{credentials:{username:"runner-space-deployer",password:"runner-space-only"}}},public_endpoint:{value:{origin:"https://app.landing-zone.runs.onstackit.cloud"}}}];
}
test("redeploying an existing release runs deploy despite the skipped publication ancestor",()=>{
const workflow=readFileSync(new URL("../../../.github/workflows/configurator-production.yml",import.meta.url),"utf8");
const deployment=workflow.split("\n deploy:\n")[1];
assert.ok(deployment,"Production deployment job is required");
const condition=deployment.match(/^ if: (.+)$/m)?.[1];
assert.match(condition??"",/always\(\)/,"A skipped publish ancestor must not add implicit success() to deploy");
assert.match(condition,/!cancelled\(\)/,"A cancelled workflow must not deploy");
assert.match(condition,/needs\.source\.result == 'success'/,"Only a verified published source may deploy");
});
test("production project binding is available to every deployment phase",()=>{
const workflow=readFileSync(new URL("../../../.github/workflows/configurator-production.yml",import.meta.url),"utf8");
const deployment=workflow.split("\n deploy:\n")[1];
Expand Down
Loading