Skip to content

ci(cli): apply upstream docs guidance in AI review - #7650

Merged
mdonnalley merged 3 commits into
developfrom
chore/cli-2681-docs-prose-lint
Nov 17, 2026
Merged

mdonnalley merged 3 commits into
developfrom
chore/cli-2681-docs-prose-lint

Conversation

@mdonnalley

Copy link
Copy Markdown
Contributor

Summary

Extend the existing AI review with advisory feedback on changed CLI reference prose, using the Supabase docs team’s current style guide rather than the retired prose linter.

A trusted preparation job resolves one upstream revision and supplies the same readable guidance snapshot to both reviewers and adjudication. Findings must quote changed prose and cite a rule at that revision. Retrieval and delivery failures are reported without blocking ordinary code review or claiming a style pass.

A local CLI reference skill shares the review procedure without copying upstream style rules. Existing review authorization and trigger behavior remain unchanged.

Closes CLI-2681.

@mdonnalley
mdonnalley requested a review from a team as a code owner November 16, 2026 20:34
@mdonnalley
mdonnalley requested a review from avallete November 16, 2026 20:34

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

CLI reference prose guidance: unavailable during trusted workflow rollout. Ordinary code review continued; no style pass is claimed.

Both independent reviews were available. Confirmed Claude's two minor operational findings: unnecessary setup delays for unrelated PRs and an unauthenticated GitHub API lookup that can lose guidance to rate limits. Corrected both findings' line references. Codex reported no findings.

Findings

Severity Location Category Sources Claim
🟡 MINOR .github/workflows/ai-review.yml:143 performance claude Both review jobs wait for toolchain provisioning and a root-filtered dependency installation even when no reference sources changed. Applicability is checked only afterward, adding avoidable setup latency to unrelated PR reviews.
🟡 MINOR .github/scripts/ai-review/docs-guidance.ts:103 reliability claude The revision lookup uses GitHub's unauthenticated REST API quota. If the runner's source-IP quota is exhausted, the collector discards guidance and reports unavailable despite the upstream documents being accessible.

Stats

Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread .github/workflows/ai-review.yml Resolved
@mdonnalley
mdonnalley added this pull request to the merge queue Nov 17, 2026
Merged via the queue into develop with commit 932b4ab Nov 17, 2026
42 checks passed
@mdonnalley
mdonnalley deleted the chore/cli-2681-docs-prose-lint branch November 17, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants