Repository navigation
feat(cli): expose consolidated Warehouse status - #7671
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed. Confirmed two non-blocking nits: a stale test target, with the behavior still covered elsewhere, and unused group descriptions. No runtime defect was established. Tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/commands/api/api-command-policy.ts:46 |
dead-code |
claude | The new replication, tables, and tables.layout group descriptions have no generated commands and currently serve no purpose. |
| ⚪ NIT | apps/cli/src/cli/command-surface/command-surface.integration.test.ts:145 |
test-coverage |
claude | The test describing self-polling result behavior still checks warehouse status, which now performs a non-waiting context read. This assertion no longer exercises its stated scenario. |
Findings outside the diff
- ⚪ NIT
apps/cli/src/cli/command-surface/command-surface.integration.test.ts:145— The test describing self-polling result behavior still checkswarehouse status, which now performs a non-waiting context read. This assertion no longer exercises its stated scenario.
Stats
Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 9 commands. Binary size: 135.3 MB, up 24.0 KB from 135.2 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
1e0478f to
65bba85
Compare
…pe-1445-warehouse-status
65bba85 to
f5b7cda
Compare
Hidden polling reads a generated link may target are now listed in `pollTargets`, each paired with the read-only generated command a failed or timed-out wait points users at. The setup read gets its own spec identity so it no longer shares `warehouse status` with the consolidated status route, and hidden targets go through the same experimental and poll-or-links checks as generated operations.
|
@bnjjj I pushed bea291a on top of your branch (no force-push) to keep this aligned with the command-generation design in #7640 before we merge it there. Summary of what changed and why: 1. Hidden polling reads now go through policy Dropping
export const pollTargets = {
"v2-get-warehouse-setup": "v2-get-warehouse-status",
};The deriver enforces it. Generation fails when:
Hidden targets also pass the same experimental-stage and "polls or links, never both" checks as generated operations. The runtime still calls the setup read through the typed 2. The setup read no longer claims The deployed spec still annotates the setup read with 3. A failed or timed-out With the setup read hidden, the hint had fallen back to a generic "inspect the operation's status" with nothing to run. It now uses the
The consolidated status route reports 4. Docs The Tests: deriver unit cases for each new failure mode, and the integration test now asserts the new hint. Generated data, unit, integration and repo-wide checks are green. |
Generate `warehouse connection` from `GET
/v2/projects/{ref}/warehouse/connection`. It prints the Arrow Flight SQL
endpoint, the TLS requirement and source-database login guidance: use a
database role with its existing password (`postgres` uses the project's
database password) and `supabase_warehouse_reader` membership. The
command never fetches or prints a password, and a disabled, unconfigured
or unavailable Warehouse shows no connection string.
Text output on terminals, raw JSON when piped or requested, and YAML
through `-o yaml`, as for the other generated Warehouse commands. Help
includes a usql recipe.
Add `connection` to the generated command vocabulary and render `TLS` as
an acronym in text labels. The contract comes from an OpenAPI override
until it ships in the deployed Management API specification.
Stacked on #7671. Depends on
supabase/platform#42053.
Implements PIPE-1449.
---------
Co-authored-by: Julien Goux <hi@jgoux.dev>
Generate
warehouse statusfromGET /v2/projects/{ref}/warehouse/status, preserving readiness, capabilities, zero-target enablement and unavailable observations through the shared runtime.Preserve
warehouse enable --waitwith selection-bound setup polling. Discover internal polling targets from response links without exposing awarehouse setups getcommand; status has no wait flags. Retain teardown waiting.Keep text output on terminals, raw JSON when piped or requested, and YAML through
-o yaml.Stacked on #7640 (including merged #7660). Depends on https://github.com/supabase/platform/pull/42039.
Implements PIPE-1445.