Skip to content

docs(cli): cover functions and sequences in db dump note (CLI-3143) - #7680

Open
7ttp wants to merge 2 commits into
developfrom
7ttp/cli-3143-db-dump-note-on-privilege-migration-covers
Open

7ttp wants to merge 2 commits into
developfrom
7ttp/cli-3143-db-dump-note-on-privilege-migration-covers

Conversation

@7ttp

@7ttp 7ttp commented Nov 17, 2026

Copy link
Copy Markdown
Member

resolves CLI-3143

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

CLI reference prose guidance: snapshot supabase/supabase@d7ead91 supplied to reviewers (advisory, not a style pass).

Both independent reviews reported the same Oxford-comma nit. Verified against the changed document and available style-guide snapshot, then merged into one confirmed advisory finding. No additional correctness issues found.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/docs/supabase/db/dump.md:15 docs-style claude+codex The changed phrase “tables, functions and sequences” omits the Oxford comma required by the supplied style guide.

Stats

Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/docs/supabase/db/dump.md Resolved
@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit 984b691 against develop at 0d1a3be · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 333 ms 314 ms no real change (-6%, within normal variation)
supabase --help help 397 ms 361 ms no real change (-9%, within normal variation)
supabase init init 346 ms 297 ms no real change (-14%, within normal variation)
supabase migration new bench migration-new 327 ms 330 ms no real change
supabase config convert config-convert 339 ms 320 ms no real change (-6%, within normal variation)
supabase config validate config-validate 357 ms 392 ms no real change (+10%, within normal variation)
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 345 ms 368 ms no real change (+7%, within normal variation)
supabase projects list projects-list 338 ms 315 ms no real change (-7%, within normal variation)
supabase functions list --project-ref replayfixtureprojref functions-list 351 ms 325 ms no real change (-7%, within normal variation)

API calls: unchanged for all 9 commands.

Binary size: 135.2 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 261-527 ms 277-532 ms -19 ms (-6%) within noise
supabase --help help 280-484 ms 276-516 ms -36 ms (-9%) within noise
supabase init init 270-388 ms 267-449 ms -49 ms (-14%) within noise
supabase migration new bench migration-new 283-360 ms 286-393 ms +3 ms (+1%) within noise
supabase config convert config-convert 275-510 ms 288-464 ms -20 ms (-6%) within noise
supabase config validate config-validate 316-539 ms 295-472 ms +34 ms (+10%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 312-433 ms 282-429 ms +23 ms (+7%) within noise
supabase projects list projects-list 292-445 ms 266-386 ms -23 ms (-7%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 283-447 ms 302-439 ms -26 ms (-7%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase config convert config-convert 0 0
supabase config validate config-validate 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db dump: Note on Privilege Migration covers tables only, so functions and sequences regain anon privileges on restore

1 participant