Skip to content

test(stack): fix 1 flaky test by giving the Pooler artifact prepare its own deadline - #7683

Open
avallete wants to merge 1 commit into
developfrom
avallete/flaky-fixes-2026-11-18
Open

avallete wants to merge 1 commit into
developfrom
avallete/flaky-fixes-2026-11-18

Conversation

@avallete

Copy link
Copy Markdown
Member

TL;DR

The native Pooler start deadline now excludes the artifact prepare, so a stall names the step that ran out of time.

  • Pooler.integration.test.ts › serves Pooler SQL against the owned database: native transaction pooler start exceeded its 60s deadline. That deadline covered the native artifact download, the prepare/provision-tenant startup commands and the server boot together. The test now runs the recipe's artifact prepare as its own phase before start, and the test guard is widened to fit both budgets.

ref

spotted in: https://github.com/supabase/cli/actions/runs/44085628022/job/134047177808


Generated by Claude Code

The native pooler start deadline covered the artifact download, the
startup commands and the server boot together, so a stall did not say
which one ran out of time. Prepare the artifact as its own phase before
start, and widen the test guard to fit both budgets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MBEk1Pbmd87VhSdE6Rb9aF
@avallete
avallete requested a review from a team as a code owner November 18, 2026 07:41
@avallete
avallete requested a review from mdonnalley November 18, 2026 07:41

Copy link
Copy Markdown
Member Author

/ai-review


Generated by Claude Code

@avallete avallete added the run-flaky-check Run the flaky-test check on this PR label Nov 18, 2026 — with Claude
@github-actions github-actions Bot removed the run-flaky-check Run the flaky-test check on this PR label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit e8aa48b against develop at 0d1a3be · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 156 ms 155 ms no real change
supabase --help help 156 ms 159 ms no real change
supabase init init 158 ms 162 ms no real change
supabase migration new bench migration-new 165 ms 174 ms no real change (+5%, within normal variation)
supabase config convert config-convert 172 ms 175 ms no real change
supabase config validate config-validate 173 ms 173 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 195 ms 199 ms no real change
supabase projects list projects-list 191 ms 200 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 190 ms 188 ms no real change

API calls: unchanged for all 9 commands.

Binary size: 135.2 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 151-161 ms 152-171 ms -2 ms (-1%) within noise
supabase --help help 152-171 ms 153-166 ms +2 ms (+1%) within noise
supabase init init 154-173 ms 153-172 ms +3 ms (+2%) within noise
supabase migration new bench migration-new 158-190 ms 159-180 ms +9 ms (+5%) within noise
supabase config convert config-convert 169-192 ms 169-200 ms +2 ms (+1%) within noise
supabase config validate config-validate 169-199 ms 169-185 ms -1 ms (0%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 185-298 ms 188-212 ms +5 ms (+2%) within noise
supabase projects list projects-list 188-239 ms 188-215 ms +9 ms (+5%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 179-211 ms 179-205 ms -2 ms (-1%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase config convert config-convert 0 0
supabase config validate config-validate 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by a newer AI review

🤖 AI Review

CLI reference prose guidance: not applicable (no reference sources changed).

Both independent reviews completed with no findings. Reading the changed test and preparation/lifecycle code revealed no actionable issue: the added preparation warms the artifact cache under a separate 60-second deadline, and the overall timeout increases to 180 seconds. CLI-reference prose review is not applicable. The supplied next-branch work shows no fundamental conflict.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

CLI reference prose guidance: not applicable (no reference sources changed).

Both independent reviews reported no findings. Reading the changed test and surrounding recipe and lifecycle code revealed no concrete issues: preparation safely warms artifacts before startup, and the test timeout increases to 180 seconds. No fundamental conflict with pending next-branch work was identified. CLI prose review was not applicable.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions

Copy link
Copy Markdown
Contributor

Flaky test check: ✅ no flaky tests

Commit 1105924b3958 · focused ×10 (5 executions each), 1 test · integration ×10, 7344 tests · unit ×10, 9942 tests · workflow run

Each execution is a separate Vitest process; Where lists failing runs, as run.iteration for suites executed more than once per run. The full data is in the flaky-check-report artifact.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants