Repository navigation
Conversation
The native pooler start deadline covered the artifact download, the startup commands and the server boot together, so a stall did not say which one ran out of time. Prepare the artifact as its own phase before start, and widen the test guard to fit both budgets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBEk1Pbmd87VhSdE6Rb9aF
|
/ai-review Generated by Claude Code |
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 9 commands. Binary size: 135.2 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
CLI reference prose guidance: not applicable (no reference sources changed).
Both independent reviews completed with no findings. Reading the changed test and preparation/lifecycle code revealed no actionable issue: the added preparation warms the artifact cache under a separate 60-second deadline, and the overall timeout increases to 180 seconds. CLI-reference prose review is not applicable. The supplied next-branch work shows no fundamental conflict.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
There was a problem hiding this comment.
🤖 AI Review
CLI reference prose guidance: not applicable (no reference sources changed).
Both independent reviews reported no findings. Reading the changed test and surrounding recipe and lifecycle code revealed no concrete issues: preparation safely warms artifacts before startup, and the test timeout increases to 180 seconds. No fundamental conflict with pending next-branch work was identified. CLI prose review was not applicable.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Flaky test check: ✅ no flaky testsCommit Each execution is a separate Vitest process; |
TL;DR
The native Pooler start deadline now excludes the artifact prepare, so a stall names the step that ran out of time.
Pooler.integration.test.ts › serves Pooler SQL against the owned database:native transaction pooler startexceeded its 60s deadline. That deadline covered the native artifact download, theprepare/provision-tenantstartup commands and the server boot together. The test now runs the recipe's artifact prepare as its own phase before start, and the test guard is widened to fit both budgets.ref
spotted in: https://github.com/supabase/cli/actions/runs/44085628022/job/134047177808
Generated by Claude Code