Skip to content

fix: delete a list of default permission rules - #1928

Open
ranjithguggilla wants to merge 1 commit into
tableau:developmentfrom
ranjithguggilla:fix/783-default-permission-delete-list
Open

ranjithguggilla wants to merge 1 commit into
tableau:developmentfrom
ranjithguggilla:fix/783-default-permission-delete-list

Conversation

@ranjithguggilla

Copy link
Copy Markdown

Closes #783

Motivation

PermissionsEndpoint.delete accepts one rule or a list. delete_default_permission accepted only one PermissionsRule, so a caller with several default rules had to delete them one at a time. Jac Fitzgerald asked for the same list behavior as the regular delete method.

Behavior change

delete_workbook_default_permissions and the other default-permission delete methods accept a list of rules as well as a single rule. Passing one rule behaves as before. Each rule is still deleted one capability at a time, which is what the REST API supports.

Test plan

test_delete_workbook_default_permissions_accepts_a_list deletes two group rules and checks that both DELETE requests are sent. The existing single-rule test still passes.

Not covered: a call against a live Tableau Server.

delete_default_permission only accepted one PermissionsRule, so a caller
with several default rules had to delete them one at a time. It now
accepts a list, matching PermissionsEndpoint.delete.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete default permissions does not take in a list

1 participant