Repository navigation
fix: delete a list of default permission rules - #1928
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
delete_default_permission only accepted one PermissionsRule, so a caller with several default rules had to delete them one at a time. It now accepts a list, matching PermissionsEndpoint.delete.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #783
Motivation
PermissionsEndpoint.deleteaccepts one rule or a list.delete_default_permissionaccepted only onePermissionsRule, so a caller with several default rules had to delete them one at a time. Jac Fitzgerald asked for the same list behavior as the regular delete method.Behavior change
delete_workbook_default_permissionsand the other default-permission delete methods accept a list of rules as well as a single rule. Passing one rule behaves as before. Each rule is still deleted one capability at a time, which is what the REST API supports.Test plan
test_delete_workbook_default_permissions_accepts_a_listdeletes two group rules and checks that both DELETE requests are sent. The existing single-rule test still passes.Not covered: a call against a live Tableau Server.