Repository navigation
fix: return a WebhookTestResultItem from webhooks.test - #1929
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
webhooks.test handed back the raw response. It now parses webhookTestResult into the destination id, HTTP status, and body.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #555
Motivation
webhooks.testreturned the raw HTTP response. The Test Webhook method returns awebhookTestResultelement with the webhook id, the destination's HTTP status, and the destination's body. Chris Shin asked for that to be parsed into an object.Behavior change
webhooks.testnow returns aWebhookTestResultItem(id,status,body) instead of the response object. Callers that read the raw response need to use those attributes.Test plan
test_testfeeds the documented response XML and checks the id, status200, and body. The rest oftest/test_webhook.pypasses.Not covered: a call against a live webhook destination.