Repository navigation
fix: omit site attributes the server version does not support - #1931
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
Site creation always sent the settings added for API 3.9, so older Tableau Servers rejected the request. Those attributes, and the ones with a documented version window, are now left out unless the negotiated API version accepts them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #806
Motivation
Creating a site sent every site setting, including the ones added for Tableau Server 2020.3 (REST API 3.9, TSC #777). Older servers reject a create-site body that contains attributes they do not know. Jac Fitzgerald asked for those attributes to be version-gated the way flow settings already are.
Behavior change
When a
Serveris passed into the site create or update request, attributes are omitted outside the API version that accepts them:dataAccelerationMode: API 3.8 through 3.15cacheWarmupEnabled: also omitted from API 3.19, where it was removedattributeCaptureEnabled: API 3.25 and laterA request built without a server still includes the attributes, so existing request snapshots stay the same. Name, content URL, admin mode, storage, subscriptions, and revision history are unchanged.
Test plan
test_create_req_omits_attributes_the_server_version_does_not_havechecks API 2.8, 3.10, 3.19, 3.24, and 3.25.test/test_site.pypasses.Not covered: creating a site on an old Tableau Server.