Repository navigation
fix: sign in over HTTPS when the server requires it - #1932
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
An http sign-in against a server that only accepts https fails with 405 after the credentials have already been sent. Probe the unauthenticated serverInfo endpoint first and switch the address to https when that probe redirects or when http is refused and https answers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1091
Motivation
Signing in to an
http://address when the server requires https fails with 405 Method Not Allowed, and the credentials have already been sent in cleartext. The issue asks the client to check the unauthenticated endpoint and switch to https before the sign-in request.Behavior change
sign_infirst GETsserverInfowith no credentials and without following redirects.serverInfoover http is left on http.Test plan
Three mocked cases: a 301 to https, a 200 over http, and a 405 on http with a 200 on https.
test/test_auth.pyandtest/test_redirect_handling.pypass.Not covered: a live server that redirects http to https.