Repository navigation
fix: publish a connection password without a username - #1934
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
Tableau Server accepts connectionCredentials that carry a password and no name, and then keeps the username already stored on the connection. TSC refused that request, so a password-only publish never embedded the password.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1926
Motivation
Publishing a workbook with a connection password and no username is rejected by TSC, even though the REST API accepts
connectionCredentialswith a password and noname. Tested on Tableau Server (REST 3.31), that request keeps the username already stored on the connection and embeds the password. tabcmd Classic does this with--db-passwordand no--db-username; tabcmd 2 uses TSC and drops the password.Behavior change
ConnectionCredentials.namemay beNone. The request then omits thenameattribute. A missing password still raisesValueError. An empty string is still sent asname="".A
ConnectionItemwith a password andembed_password, and no username, is sent the same way.Test plan
test_publish_connection_password_without_a_namechecks aConnectionCredentialswith no name, aConnectionItemwith only a password, and an empty-string name.test_publish_connection_credentials_require_a_passwordchecks the missing-password error. The existing named-credential publish tests still pass.Not covered: a publish against Tableau Server.