Repository navigation
fix: send encryptExtracts when publishing a workbook - #1935
Open
ranjithguggilla wants to merge 1 commit into
Open
ranjithguggilla wants to merge 1 commit into
ranjithguggilla wants to merge 1 commit into
Conversation
The publish workbook method documents an optional encryptExtracts attribute, and TSC already sends it for data sources. A workbook had no way to set it, so publish could not choose extract encryption.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1925
Motivation
Publish Workbook documents an optional
encryptExtractsattribute. TSC sends it for a data source and reads it back on a workbook, but a workbook has no setter and the publish request never includes it. tabcmd'spublish --encrypt-extractstherefore has no effect.Behavior change
WorkbookItem.encrypt_extractscan be set. The workbook publish request sendsencryptExtractsastrueorfalsewhen the value is set, and omits it when the value is stillNone.Test plan
test_publish_sends_encrypt_extracts_when_setchecks the omitted,true, andfalserequest bodies.Not covered: a publish against Tableau Server.