Skip to content

fix: send encryptExtracts when publishing a workbook - #1935

Open
ranjithguggilla wants to merge 1 commit into
tableau:developmentfrom
ranjithguggilla:fix/1925-workbook-encrypt-extracts
Open

ranjithguggilla wants to merge 1 commit into
tableau:developmentfrom
ranjithguggilla:fix/1925-workbook-encrypt-extracts

Conversation

@ranjithguggilla

Copy link
Copy Markdown

Closes #1925

Motivation

Publish Workbook documents an optional encryptExtracts attribute. TSC sends it for a data source and reads it back on a workbook, but a workbook has no setter and the publish request never includes it. tabcmd's publish --encrypt-extracts therefore has no effect.

Behavior change

WorkbookItem.encrypt_extracts can be set. The workbook publish request sends encryptExtracts as true or false when the value is set, and omits it when the value is still None.

Test plan

test_publish_sends_encrypt_extracts_when_set checks the omitted, true, and false request bodies.

Not covered: a publish against Tableau Server.

The publish workbook method documents an optional encryptExtracts
attribute, and TSC already sends it for data sources. A workbook had
no way to set it, so publish could not choose extract encryption.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish workbook: support the encryptExtracts request attribute

1 participant