Repository navigation
fix: clean file:// URL prefixes when stripping cwd in clean() and parseLine() - #79
Open
chiragbitoni wants to merge 1 commit into
Open
chiragbitoni wants to merge 1 commit into
chiragbitoni wants to merge 1 commit into
Conversation
…seLine() When error stacks originate in ESM modules, paths are formatted as file:// URLs. Previously, clean() only stripped \/ leaving file:// at the start of relative paths. Similarly, parseLine() failed to strip cwd from file:// URLs in setFile(). Handle file:// and file:/// URL prefixes matching cwd when normalizing paths. Fixes tapjs#60 Signed-off-by: Chirag Bitoni <chiragbitoni4994@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When error stack traces originate from ESM modules, Node formats file paths as
file://URLs (e.g.at file:///user/dev/project/test.mjs:6:9).Previously,
clean()stripped${this._cwd}/, leaving invalid paths likefile://test.mjs:6:9instead oftest.mjs:6:9.Similarly,
parseLine()'ssetFile()helper only checkedfilename.startsWith(${cwd}/), failing to strip cwd fromfile://-prefixed filenames.This PR:
file:///andfile://prefixes when matching and stripping the configuredcwdinclean().setFile()to recognizefile:///andfile://prefixes matchingcwd.clean()andparseLine()on Linux and Windowsfile://formats with 100% test coverage.Fixes #60
Checklist