Skip to content

ngclient: Stop using a symlink - #3047

Open
jku wants to merge 1 commit into
theupdateframework:developfrom
jku:no-symlinks
Open

jku wants to merge 1 commit into
theupdateframework:developfrom
jku:no-symlinks

Conversation

@jku

@jku jku commented Nov 18, 2026

Copy link
Copy Markdown
Member

symlink was used to

  • be more certain root.json is an actual root file that matches a file in root_history/
  • Save a few KB in storage

but it has been very problematic: OS specific issues, races, non-atomic operations. Let's just use a normal file.

Assisted-by: Antigravity with Gemini 4 Carbon

This should fix the issues listed in #3010: @Sachith77, @albertvillanova your review is appreciated if you're interested.

symlink was used to
* be more certain root.json is an actual root file that matches
  files in root_history/
* Save a few KB in storage

but it has been very problematic: OS specific issues, races, non-atomic
operations. Let's just use a normal file.

Assisted-by: Antigravity with Gemini 4 Carbon
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
jku requested a review from a team as a code owner November 18, 2026 14:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant