Repository navigation
fix: pre-release audit findings since v1.10.0 - #874
Conversation
…ation A platform from v1.10.0 accepts the manifest's `database` field but ignores it and keeps D1 read replication on, so `readReplication: false` was dropped without notice. The platform now advertises `d1ReadReplication` in `/capabilities`, and `void deploy` asks for it before any upload, only when the manifest carries the setting. Without it the deploy stops and tells the user to upgrade the platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cf 1.0.0-rc.0 and @cloudflare/vite-plugin 2.0.0-rc.0 depend on exactly 1.0.0-rc.0 of both packages, but void used a caret range. A fresh install resolved 1.0.0-rc.1 for void and nested rc.0 copies for cf and the plugin, so void read plugin build output with a different copy than the one that wrote it. Pin both to 1.0.0-rc.0, add them to the pin rule, and make the packed consumer check assert one copy of each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed D1 ingest replies with status 'error' and puts the SQL error in errors[] and progress in messages[]. The import read only 'error', so the user saw 'Unknown import error.'. Show error, errors and messages, as wrangler does, with terminal escape sequences removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One 10-minute signal covered the upload, ingest and every poll, so a large file failed with a bare timeout while D1 could still be ingesting it. Like wrangler, the import now has no overall deadline; each D1 API request gets its own 2-minute limit. Once ingest has been requested, a failure that D1 did not report (network error, request timeout, bad reply) says the import may still be running and names the bookmark, so the user checks the database before running the file again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since #863 every direct D1 `db execute --remote --file` ran as a D1 import, so a read-only file printed no rows (1.10.0 and the hosted path do) and the database stopped serving queries with no warning or prompt. Files up to 100,000 bytes, D1's maximum statement length, now go through the query path again; it already sends large SQL in a file, not argv. Larger files still run as an import, after a warning that the database cannot serve queries until it finishes, and a TTY always asks first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ding A sending-only app (no email/ handlers) that already carries the SEND_EMAIL binding, on an account that cannot onboard Email Sending (Workers Free), was asked "Set up email?" on every interactive deploy, and each yes retried `email sending enable`. CI told it to run `void email setup`, which fails the same way. Readiness stays strict: a sending-only app is ready only once its domain is onboarded for Email Sending, since Void never enables Email Routing for it and Cloudflare allows verified-destination sends only from routing domains. - Deploy treats that saved state like a ready one: no prompt and no account call, the sender var is still kept current, the existing binding ships, and the step returns not satisfied, so --require-email still exits 1. - Deploy, `void email status` and `void email setup` print the same Workers Paid message: the product, the plan link and the token permissions (Zone Read + Email Sending Edit). `setup` asks a specific onboarding question. - The checklist and address map no longer promise verified-destination sends to sending-only apps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sending-only apps need Email Sending, which requires Workers Paid; only apps with email/ handlers keep inbound mail and verified-recipient sends on Workers Free. Deploys don't retry onboarding once setup is saved. The CI token needs Zone Read and Email Sending Edit, plus Email Routing Edit with email/ handlers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`void init` bootstraps `vp install` through npx when Vite+ is neither installed nor on PATH. A `catalog:default` spec only looked at `catalogs.default`, a `catalog:` spec only at the top-level `catalog`, and Yarn's `.yarnrc.yml` catalogs were never read, so init stopped with "Could not resolve the project's Vite+ version". Treat `catalog:` and `catalog:default` as the same catalog, read `.yarnrc.yml` in the same walk, and fall back to the CLI's own Vite+ version (the 1.10.0 behavior) instead of throwing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The starter summary printed only its one-line description, so an edit to the workspace root's pnpm-workspace.yaml (approved builds) was never shown. 1.10.0 logged it. Keep hiding the starter's own files, but list files outside the new app and later changes to files that existed before init under the starter line, both in the summary and when setup stops early. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`ai.provider().fetch()` now forwards the caller's signal. When that
signal aborted a `text/event-stream` response, the stream wrapper caught
the read error, added a "Generation was interrupted" `void:error` event
and closed normally, so `response.text()` resolved instead of rejecting.
When the caller's signal has aborted, error the stream with its reason.
Other mid-stream failures keep the `void:error` / `void:limit` event, and
`ai.stream()` / `ai.run({ stream: true })` are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-release-audit-findings-void-cloud.voidzero-docs.workers.dev (commit 0c631b5)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Can you make sure those two things work correctly? Additional Slop Review:
|
Runs `void db execute --remote --file` without a TTY through the real operation process against a fake D1 import API. It checks that no prompt appears and that no child process gets the SQL in argv or env. On the 1.10.0 code path it fails with the same spawnSync E2BIG error as nkzw-tech/pocket-folio run 44115320833. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Skips the remote confirmation prompt in a TTY, like `db reset`, `db seed` and `db restore` (and wrangler's `d1 execute --yes`). CI never prompts, so the flag is optional there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Direct D1 files up to 100 KB now go through `cf d1 query`, which sends the SQL as is. The query API fails on CRLF inside a trigger body with SQLITE_ERROR 7500, while the import API took the same bytes. A small scanner turns structural CRLF into LF and keeps line endings inside quoted values and identifiers, like wrangler's fix in cloudflare/workers-sdk#15044. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The presigned upload PUT had no deadline, so a stalled upload hung. It now gets the 2-minute request bound plus time to send the file at 1 Mbit/s (5 minutes 20 seconds for 25 MB), and a timeout says so. When D1 already has a file with the same etag, init itself starts the import. So an init that fails without an answer from D1 (timeout, lost connection, 5xx, non-JSON), or a reply with no upload URL and no bookmark, now says the import may still be running. An init that D1 refused (4xx), a reported import error, and upload failures stay plain failures, since D1 did not start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drives runCloudflareEmailStep for a sending-only app in CI with an API token (email.from on a subdomain of the zone, Email Sending onboarded, Email Routing off, SEND_EMAIL and __VOID_EMAIL_FROM committed). The step prints nothing, never touches Email Routing, and the post-deploy map is one neutral outbound line. On v1.10.0 the same input read Email Routing and warned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed zone
The cf `email.sending.settings` / `email.sending.enable` operations first
locate the zone with `email-routing settings get`, which needs Zone
Settings Read. A token scoped as documented for sending-only apps (Zone
Read + Email Sending Edit) fails that read, so preflight marked sending
unknown: CI printed the checklist and the "not fully set up" warning, and
--require-email refused an onboarded Workers Paid domain.
Sending-only apps already resolve the zone with the session bearer
(GET /zones?name=). Preflight now reads
GET /zones/{zone}/email/sending/subdomains with the same bearer, and
`void email setup` onboards with POST to the same path, so the
documented token is enough. OAuth sessions use the same bearer. Inbound
apps keep the provider operations.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also list --yes on the inline remote usage line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When sending-only onboarding cannot borrow the session bearer, nothing reached Cloudflare, so the plan hint was misleading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, I checked both against pocket-folio's CI logs (runs 44115320833 and 44223850886) and pushed fixes in 29bf2b7..0c631b5. 25 MB Sending-only email in CI. With your setup (no The pasted review notes
|
cpojer
left a comment
There was a problem hiding this comment.
Nice, thank you for doing this pass.
Fixes the problems found in a pre-release audit of
v1.10.0..main. Each one was checked against the real control flow and reproduced before it was fixed. Each fix was then reviewed by a separate agent.What changed
database.readReplicationwas silently ignored (andfalseundone) on a platform that predates it (self-hosted 1.10.0, or hosted before prod deploy)/capabilitiesnow advertisesd1ReadReplication. The CLI checks it before uploading anything, and only when the app sets the optioncf/@cloudflare/vite-pluginpinned to rc.0, but@cloudflare/config/build-output-utilsstayed^, so fresh installs got two copies1.0.0-rc.0. Add them to the AGENTS.md pin rule and the deps skill.packed-consumer.mjsnow asserts a single copydb execute --remote --file(direct D1)Unknown import error.errors[]/messages[]like wrangler (sanitized)--fileran as a bulk import: no rows, and the DB paused with no warning--yesskips the prompt; CI never promptscf d1 query, as in wrangler #15044--remote --filein CI failed withE2BIGon 1.10.0SEND_EMAILbinding were asked "Set up email?" and retried onboarding on every deploy. Errors didn't name the paid planvoid email setupowns the retry). Deploy,email statusandemail setupprint one message that names Email Sending + Workers Paid, links the plan page, and lists the token permissionsdomains.md,cli/email.md,integrations/cloudflare.mdvoid initvite-plususedcatalog:defaultor a Yarn catalogcatalog/catalogs.defaultand.yarnrc.yml. When nothing is found, fall back to the CLI's version (1.10.0 behavior)pnpm-workspace.yaml)ai.provider().fetch()ended with a fakevoid:erroreventai.stream()/ai.run({ stream: true })are unchangedDecisions
email/handlers (that protects MX). So it can't confirm that "verified destinations only" works.--require-emailstill fails for these apps, now with a clear Workers Paid message. Deploys without the flag still ship the saved binding./capabilities, not the platform version. Hosted reportsversion: 'hosted', which skips the version check, so raisingMIN_PLATFORM_VERSIONalone would not cover it.Not fixed (checked and dropped)
#868retry window looked short: refuted. Each re-read spawns a subprocess, so the real window is several seconds, and the issue asked for exactly this short backoff._dmarc/bounce record) still sees the prompt on each deploy. The checklist names the conflict the user must fix.Release notes for the next version
database.readReplication). Existing databases keep replicas until set tofalseand redeployed. Self-hosted platforms must be upgraded before apps set this option.MIN_PLATFORM_VERSIONin the release commit as usual.#863can be closed after this ships.Verification
vp check: clean (aftervp run build:allandnuxi prepareto regenerate playground types).main.vp run test --base 29bf2b7c1passes 591/591 affected files, browser tests included.vp test run: 791/828 files passed on the first run. All 36 failures were browser tests missing the new Playwright chromium build (1255). After installing it, 35 of the 36 passed. The last one (http-errors-playgrounddev history navigation) timed out under load and then passed 4 of 4 runs alone. This PR doesn't touch Pages or navigation code.🤖 Generated with Claude Code