Skip to content

Retry stale Durable Object binding verification reads after Worker upload - #880

Open
iPLAYCAFE-dev wants to merge 1 commit into
voidzero-dev:mainfrom
iPLAYCAFE-dev:fix/retry-do-binding-verification
Open

iPLAYCAFE-dev wants to merge 1 commit into
voidzero-dev:mainfrom
iPLAYCAFE-dev:fix/retry-do-binding-verification

Conversation

@iPLAYCAFE-dev

Copy link
Copy Markdown
Contributor

Fixes transient Application custom Durable Object binding could not be verified. errors right after uploadDeploymentWorker uploads a Worker carrying custom Durable Object bindings.

Summary

  • Updates verifyManagedDurableObjectApplicationBindings in platform/packages/api/src/provisioning/durable-objects.ts to retry stale/empty readBindings results across bounded delays ([250, 500, 1_000] ms by default, matching the deployment readback retry pattern from platform upgrade: post-activation lineage check fails on a stale deployments read ("changed concurrently after activation") #868) before failing.
  • Keeps immediate success on 1st read (0 extra API calls when consistent) and allows overriding delaysMs in tests.
  • Adds unit tests in platform/packages/api/test/unit/deploy-durable-objects.test.ts covering immediate match, recovery after a stale/empty initial read, and failure when bindings never match.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant