Repository navigation
fix: Move Node to 22.23.5 for the November 2026 Node security release - #48
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from Devin Bot
|
[Medium impact] The changes appear safe to merge; no actionable issues were found. SummaryUpdates the agent runtime to Node 22.23.5 while keeping the embedded Dockerfile in sync.
No actionable issues found. Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
Summary
Moves the agent-runtime base image to Node 22.23.5, the patched 22.x release in the November 2026 Node.js security release (High-severity CVEs in http2, tls, http and llhttp). Same pattern as #43.
images/agent-runtime/Dockerfileand in the embedded copysrc/isolation/image-contexts.generated.ts, regenerated withbun scripts/generate-image-contexts.ts(the drift test checks the two match).docker buildx imagetools inspect node:22.23.5-bookworm-slimreturns this digest with linux/amd64, linux/arm64/v8, linux/arm/v7 and linux/ppc64le. An earlier index from the first publish was amd64 and ppc64le only, so I pinned this one after arm64 landed..nvmrc,engines.nodeor 22.x CI pin.release.yml'snode-version: 24is only for npm trusted publishing and is out of scope.fix:commit.Users must rebuild: quickstudy is a distributed CLI, and existing local
quickstudy/agent-runtimeimages keep the old Node until users run:Tested locally:
bun test(554 pass, 11 skipped),bun run typecheckandbun run lintall pass. Adocker build images/agent-runtimeon amd64 produced an image whosenode --versionisv22.23.5.CI note: the PR jobs fail before running any code.
workos/setup-socket-firewallreportsSOCKET_FIREWALL_TOKEN is unavailable outside an explicitly permitted public external-fork pull request. Every quickstudy pull_request run since Nov 10 (#46, #47) fails the same way, while push runs onmainpass.Link to Devin session: https://app.devin.ai/sessions/b36e0d47bf744bbf86b553d0c890ede0
Open in Devin Desktop: https://app.devin.ai/desktop/session/b36e0d47bf744bbf86b553d0c890ede0?variant=devin
Requested by: @peakematt
🟢 Devin Review found nothing to fix · View findings