Skip to content

fix: Move Node to 22.23.5 for the November 2026 Node security release - #48

Merged
gjtorikian merged 2 commits into
mainfrom
devin/1794416472-node-22.23.5
Nov 18, 2026
Merged

gjtorikian merged 2 commits into
mainfrom
devin/1794416472-node-22.23.5

Conversation

@peakematt

@peakematt peakematt commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Moves the agent-runtime base image to Node 22.23.5, the patched 22.x release in the November 2026 Node.js security release (High-severity CVEs in http2, tls, http and llhttp). Same pattern as #43.

-FROM node:22.23.4-bookworm-slim@sha256:de170b39439eb0e5a3444ad7d60b015614a381e10fecae2e30ec9e735122f38d
+FROM node:22.23.5-bookworm-slim@sha256:e9f565d32859f0cbfb52125eafe8be39390f24dac302dc3cdf566e8ba3ab21ee
  • Changed in images/agent-runtime/Dockerfile and in the embedded copy src/isolation/image-contexts.generated.ts, regenerated with bun scripts/generate-image-contexts.ts (the drift test checks the two match).
  • The digest is the multi-arch index. docker buildx imagetools inspect node:22.23.5-bookworm-slim returns this digest with linux/amd64, linux/arm64/v8, linux/arm/v7 and linux/ppc64le. An earlier index from the first publish was amd64 and ppc64le only, so I pinned this one after arm64 landed.
  • This is the only Node pin. The harness runs on Bun, so there's no .nvmrc, engines.node or 22.x CI pin. release.yml's node-version: 24 is only for npm trusted publishing and is out of scope.
  • No CHANGELOG edit: release-please writes the entry from this fix: commit.

Users must rebuild: quickstudy is a distributed CLI, and existing local quickstudy/agent-runtime images keep the old Node until users run:

quickstudy images build --pull

Tested locally: bun test (554 pass, 11 skipped), bun run typecheck and bun run lint all pass. A docker build images/agent-runtime on amd64 produced an image whose node --version is v22.23.5.

CI note: the PR jobs fail before running any code. workos/setup-socket-firewall reports SOCKET_FIREWALL_TOKEN is unavailable outside an explicitly permitted public external-fork pull request. Every quickstudy pull_request run since Nov 10 (#46, #47) fails the same way, while push runs on main pass.

Link to Devin session: https://app.devin.ai/sessions/b36e0d47bf744bbf86b553d0c890ede0
Open in Devin Desktop: https://app.devin.ai/desktop/session/b36e0d47bf744bbf86b553d0c890ede0?variant=devin
Requested by: @peakematt


🟢 Devin Review found nothing to fix · View findings

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from Devin Bot

In the workos/quickstudy repository, open a PR to update Node for the November 2026 Node.js security release. Move it to Node 22.23.5 (the patched 22.x release; notes: https://github.com/nodejs/node/releases/tag/v22.23.5).

Context: Node 22.23.5, 24.22.3 and 26.13.1 shipped on Nov 11, 2026, fixing High-severity CVEs in http2, tls, http and llhttp (advisory: https://nodejs.org/en/blog/vulnerability/november-2026-security-releases). This PR is one row in the security team's rollout tracker; Matt Peake (security) asked for it.

  • PR title: "Move Node to 22.23.5 for the November 2026 Node security release" (keep any title prefix the repo's conventions require, e.g. "chore:" / "fix:" as last time).
  • Last time's PR for this repo, to use as the pattern: fix: pin agent runtime to patched Node 22.23.4 #43. Update the same kinds of pins (mise/.nvmrc/.node-version, engines, CI node-version, Dockerfile base images and their sha256 digests or checksums, smoke tests asserting the version). Don't rewrite historical docs, evidence or changelog entries other than adding a new one if the repo keeps a changelog.
  • Tracker note for this row: Distributed CLI. Users need to run quickstudy images build --pull.
  • If a Docker base image tag for the new version (Docker Hub node:, dhi.io/node:) is not published yet, check again every ~20 minutes for up to 3 hours. If it is still missing, open the PR with every pin you can change and say in the PR body which image is still pending, or report blocked if nothing can change yet.
  • If the repo no longer uses Node, or is already on the patched version, don't open a PR; report n/a with the reason.
  • Don't merge or approve anything. Follow the repo's PR template and pre-commit hooks, and get CI green.

Deliverable: the PR URL (or the n/a / blocked reason) in your structured output.

@peakematt
peakematt marked this pull request as ready for review November 18, 2026 21:24
@gjtorikian
gjtorikian merged commit ce88fbe into main Nov 18, 2026
13 of 14 checks passed
@gjtorikian
gjtorikian deleted the devin/1794416472-node-22.23.5 branch November 18, 2026 21:25

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes appear safe to merge; no actionable issues were found.

Summary

Updates the agent runtime to Node 22.23.5 while keeping the embedded Dockerfile in sync.

  • Rebuilt agent containers now use Node 22.23.5.

No actionable issues found.

Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants