Skip to content

ci: Allow Socket Firewall fork fallback in release builds - #51

Merged
gjtorikian merged 1 commit into
mainfrom
devin/1795037167-sfw-fork-fallback
Nov 18, 2026
Merged

gjtorikian merged 1 commit into
mainfrom
devin/1795037167-sfw-fork-fallback

Conversation

@peakematt

@peakematt peakematt commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

release.yml's build and pack-check jobs run on pull requests too. Fork PRs don't get PUBLIC_SOCKET_FIREWALL_TOKEN, so without the fallback all four binary builds and the tarball self-check fail on any fork PR. This adds allow-external-fork-fallback: true to those two setup-socket-firewall steps, the same as lint and test since #50. The publish job is unchanged: it still needs the token.


🟢 Devin Review found nothing to fix · View findings

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Prompt hidden (unlisted session)

@peakematt
peakematt marked this pull request as ready for review November 18, 2026 21:33

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Allows fork pull requests to use Socket Firewall fallback during binary builds and the tarball self-check.

  • Fork pull requests can build binaries and check release packages.

No actionable issues found.

Reviews (1) · Last reviewed commit: "ci: Allow Socket Firewall fork fallback ..." · Reviewed by Greptile

@gjtorikian

Copy link
Copy Markdown
Collaborator

the other OSS repos have this, so seems sensible to add here too.

@gjtorikian
gjtorikian merged commit ce72e3e into main Nov 18, 2026
17 checks passed
@gjtorikian
gjtorikian deleted the devin/1795037167-sfw-fork-fallback branch November 18, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants