Repository navigation
ci: Allow Socket Firewall fork fallback in release builds - #51
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Prompt hidden (unlisted session) |
peakematt
marked this pull request as ready for review
November 18, 2026 21:33
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAllows fork pull requests to use Socket Firewall fallback during binary builds and the tarball self-check.
No actionable issues found. Reviews (1) · Last reviewed commit: "ci: Allow Socket Firewall fork fallback ..." · Reviewed by Greptile |
Collaborator
|
the other OSS repos have this, so seems sensible to add here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml'sbuildandpack-checkjobs run on pull requests too. Fork PRs don't getPUBLIC_SOCKET_FIREWALL_TOKEN, so without the fallback all four binary builds and the tarball self-check fail on any fork PR. This addsallow-external-fork-fallback: trueto those twosetup-socket-firewallsteps, the same as lint and test since #50. The publish job is unchanged: it still needs the token.🟢 Devin Review found nothing to fix · View findings