Repository navigation
Fix: prevent requesters from approving own reservations - #93
Merged
Merged
Conversation
2 tasks done
2 tasks done
Rom1-B
requested review from
a team,
Mary-Clb,
MyvTsv and
RomainLvr
and removed request for
a team
November 16, 2026 12:57
Mary-Clb
reviewed
Nov 16, 2026
Comment on lines
+271
to
+272
| // Answering is a validator action: the requester (who passes canUpdateItem() on a fresh ticket) | ||
| // must not approve their own request, so require the right core asks to reserve on behalf of others. |
There was a problem hiding this comment.
The comment is confusing: a technician can still see the Approve/Refuse actions on their own request and approve it (reproduced on a local instance with the default tech user and Technician profile).
Mary-Clb
requested changes
Nov 16, 2026
Mary-Clb
approved these changes
Nov 16, 2026
RomainLvr
approved these changes
Nov 17, 2026
Contributor
|
Backport-action backported this pull request in workflow run 44055178769.
|
3 of 4 tasks
Rom1-B
added a commit
that referenced
this pull request
Nov 17, 2026
Forward-port of #93 to `main`. ## Checklist before requesting a review *Please delete options that are not relevant.* - [x] I have performed a self-review of my code. - [x] I have added tests (when available) that prove my fix is effective or that my feature works. - [x] I have updated the CHANGELOG with a short functional description of the fix or new feature. - [ ] This change requires a documentation update. ## Description - It fixes #68 - Any requester, including self-service users on the simplified interface, could approve or refuse their own reservation request from the ticket timeline, as long as the ticket had no followup or task yet. - Answering a reservation request now requires the standard interface and the right to create reservations for other users, so only actual validators see and can use the approve/refuse actions. ## Screenshots (if appropriate): Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Screenshots (if appropriate):