Skip to content

[main] Fix: prevent requesters from approving own reservations - #94

Merged
Rom1-B merged 1 commit into
mainfrom
forward-port/93-to-main
Nov 17, 2026
Merged

Rom1-B merged 1 commit into
mainfrom
forward-port/93-to-main

Conversation

@glpi-project

@glpi-project glpi-project Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Forward-port of #93 to main.

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes Issue with material reservation approval #68
  • Any requester, including self-service users on the simplified interface, could approve or refuse their own reservation request from the ticket timeline, as long as the ticket had no followup or task yet.
  • Answering a reservation request now requires the standard interface and the right to create reservations for other users, so only actual validators see and can use the approve/refuse actions.

Screenshots (if appropriate):

## Checklist before requesting a review

*Please delete options that are not relevant.*

- [x] I have performed a self-review of my code.
- [x] I have added tests (when available) that prove my fix is effective
or that my feature works.
- [x] I have updated the CHANGELOG with a short functional description
of the fix or new feature.
- [ ] This change requires a documentation update.

## Description

- It fixes #68
- Any requester, including self-service users on the simplified
interface, could approve or refuse their own reservation request from
the ticket timeline, as long as the ticket had no followup or task yet.
- Answering a reservation request now requires the standard interface
and the right to create reservations for other users, so only actual
validators see and can use the approve/refuse actions.

## Screenshots (if appropriate):

(cherry picked from commit b0fe8cf)
@Rom1-B
Rom1-B merged commit 9830076 into main Nov 17, 2026
7 checks passed
@Rom1-B
Rom1-B deleted the forward-port/93-to-main branch November 17, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with material reservation approval

1 participant