Repository navigation
Conversation
Adds reviewSession, reviewProposal and nextProposalToReview queries and a voteProposal mutation for the new Focus Mode screen. Every field checks the same access as the old review page. A vote without a score option saves "No vote". Votes only accept the session's own score options, keep the private comment, and cancelled proposals are never returned. Pitch and abstract are rendered from markdown with the same filter as the old page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Adds admin GraphQL operations ( Minor: No other issues found. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## claude/cfp-review-beta-shell #4868 +/- ##
================================================================
+ Coverage 92.61% 92.66% +0.04%
================================================================
Files 360 367 +7
Lines 10958 11098 +140
Branches 953 959 +6
================================================================
+ Hits 10149 10284 +135
- Misses 684 689 +5
Partials 125 125 🚀 New features to boost your workflow:
|
Stacked on #4867. Part 2 of 3 of the new CFP review pages (beta).
What
Admin GraphQL operations for Focus Mode, in a new
api/reviews/module laid out likeapi/schedule/:reviewSession(reviewSessionId): score options, best first, and the tags used by the conference's proposals, for the tag filter.reviewProposal(reviewSessionId, proposalId): everything the old review page shows, plus the proposal's tags, the speaker's gender, how many proposals they sent ("2 of 3" when the conference has a limit) and links to their other proposals. Elevator pitch and abstract come back as HTML, rendered with the samemarkdownifyfilter as the old page.nextProposalToReview(reviewSessionId, excludeTags, seen): reuses the old page's queue (ProposalsReviewAdapter.get_next_to_review_item_id, fewest scored votes first). Skipped proposals come back once nothing new is left, as today.voteProposal(input): saves or updates the reviewer's vote. LeavingscoreOptionIdempty saves "No vote" (Let reviewers abstain on proposals and grants #4864).Differences from the old review page:
CanReviewSession, the same check as the old review page./admin/graphqluses the same schema as the public/graphql, so the Django view's access check doesn't cover it.countrynamefilter looks up byalpha_2, but ourcountrieshelper calls that fieldcode, so the old page always shows it empty. The old page itself is unchanged here.backend/schema.graphqlis regenerated. No database changes.Testing
pytest api/reviews reviews/tests: 123 passed.<script>tag removed, cancelled and other-conference proposals not found, skipped proposals coming back, updating a vote while keeping the private comment, a score option from another session being refused, and saving "No vote".