Repository navigation
fix(web): raise an error when apps_icon_set gets neither file nor url - #2060
Merged
Merged
Conversation
Co-authored-by: Michael Brooks <21328+mwbrooks@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
+ Coverage 84.60% 84.63% +0.02%
==========================================
Files 118 118
Lines 14061 14067 +6
==========================================
+ Hits 11896 11905 +9
+ Misses 2165 2162 -3 ☔ View full report in Codecov by Harness. |
Member
Author
|
🌟 Thanks for the kind review @mwbrooks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes
apps_icon_setraise aSlackRequestErrorwhen it gets neitherfilenorurl, following the review on #2058.missing_arguments. Now it fails before the request, the wayviews_updateandfiles_uploaddo when their required pair is missing.scripts/codegen.py, and sync and async tests check the error.Testing
client.apps_icon_set(app_id=...)with neither argument and confirmSlackRequestError: Either file or url must be provided.with no request sent.file=orurl=and confirm it still sets the icon.Live check: on
main, the same call with neither argument returnsmissing_argumentsfrom the API.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code