Skip to content

fix(web): raise an error when apps_icon_set gets neither file nor url - #2060

Merged
mwbrooks merged 1 commit into
mainfrom
zimeg-fix-apps-icon-set-file-or-url
Nov 18, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
zimeg-fix-apps-icon-set-file-or-url

fix(web): raise an error when apps_icon_set gets neither file nor url

d471404
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2026 in 1s

84.63% (+0.02%) compared to e1811b7

View this Pull Request on Codecov

84.63% (+0.02%) compared to e1811b7

Details

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.63%. Comparing base (e1811b7) to head (d471404).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
slack_sdk/web/legacy_client.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
+ Coverage   84.60%   84.63%   +0.02%     
==========================================
  Files         118      118              
  Lines       14061    14067       +6     
==========================================
+ Hits        11896    11905       +9     
+ Misses       2165     2162       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.