Repository navigation
feat(cli): add generated Warehouse disable command - #7660
Merged
bnjjj merged 2 commits intoNov 17, 2026
Merged
Conversation
bnjjj
marked this pull request as ready for review
November 17, 2026 13:05
bnjjj
requested review from
avallete and
jgoux
and removed request for
a team
November 17, 2026 13:05
Contributor
There was a problem hiding this comment.
🤖 AI Review
Confirmed Claude’s finding: the new warehouse disable command makes the hosted-consent snapshot stale. Codex reported no findings, and the adjudication pass found no additional issues. Verification was static; tests were not run because dependencies are absent.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/command-internal/hosted-consent/hosted-consent-coverage.unit.test.ts:138 |
test-coverage |
claude | The consent-default snapshot omits the new warehouse disable command, causing this unit test to fail. The warehouse-enabled command tree now contributes "warehouse disable": "no" to consentDefaultByLeaf. |
Findings outside the diff
- 🟡 MINOR
apps/cli/src/command-internal/hosted-consent/hosted-consent-coverage.unit.test.ts:138— The consent-default snapshot omits the new warehouse disable command, causing this unit test to fail. The warehouse-enabled command tree now contributes "warehouse disable": "no" to consentDefaultByLeaf.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
jgoux
added a commit
that referenced
this pull request
Nov 17, 2026
Generate `warehouse status` from `GET
/v2/projects/{ref}/warehouse/status`, preserving readiness,
capabilities, zero-target enablement and unavailable observations
through the shared runtime.
Preserve `warehouse enable --wait` with selection-bound setup polling.
Discover internal polling targets from response links without exposing a
`warehouse setups get` command; status has no wait flags. Retain
teardown waiting.
Keep text output on terminals, raw JSON when piped or requested, and
YAML through `-o yaml`.
Stacked on #7640 (including merged #7660). Depends on
supabase/platform#42039.
Implements PIPE-1445.
---------
Co-authored-by: Julien Goux <hi@jgoux.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generated
warehouse disableandwarehouse teardowns getcommands with explicit--delete-data, bounded waiting, and the existing Warehouse feature gate.Retain data by default, poll the accepted cleanup identity, and include the last observed lifecycle state in timeout errors. Reuse shared targeting, consent, output, and error handling.
warehouse teardowns getreads current cleanup without an ID. Optional--operation-idpins observation;warehouse disable --waitsupplies its ID automatically.Stacks on #7640. Depends on https://github.com/supabase/platform/pull/42016.
Implements PIPE-1447. Keeps the local request-preview contract; resolved impact previews remain follow-up work.