Skip to content

feat(cli): add generated Warehouse disable command - #7660

Merged
bnjjj merged 2 commits into
feat/generated-warehouse-commandsfrom
bnjjj/pipe-1447-warehouse-disable
Nov 17, 2026
Merged

bnjjj merged 2 commits into
feat/generated-warehouse-commandsfrom
bnjjj/pipe-1447-warehouse-disable

Conversation

@bnjjj

@bnjjj bnjjj commented Nov 17, 2026 •

Copy link
Copy Markdown

Add generated warehouse disable and warehouse teardowns get commands with explicit --delete-data, bounded waiting, and the existing Warehouse feature gate.

Retain data by default, poll the accepted cleanup identity, and include the last observed lifecycle state in timeout errors. Reuse shared targeting, consent, output, and error handling.

warehouse teardowns get reads current cleanup without an ID. Optional --operation-id pins observation; warehouse disable --wait supplies its ID automatically.

Stacks on #7640. Depends on https://github.com/supabase/platform/pull/42016.

Implements PIPE-1447. Keeps the local request-preview contract; resolved impact previews remain follow-up work.

@bnjjj
bnjjj marked this pull request as ready for review November 17, 2026 13:05
@bnjjj
bnjjj requested review from a team and supabase-oss as code owners November 17, 2026 13:05
@bnjjj
bnjjj requested review from avallete and jgoux and removed request for a team November 17, 2026 13:05

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Confirmed Claude’s finding: the new warehouse disable command makes the hosted-consent snapshot stale. Codex reported no findings, and the adjudication pass found no additional issues. Verification was static; tests were not run because dependencies are absent.

Findings

Severity Location Category Sources Claim
🟡 MINOR apps/cli/src/command-internal/hosted-consent/hosted-consent-coverage.unit.test.ts:138 test-coverage claude The consent-default snapshot omits the new warehouse disable command, causing this unit test to fail. The warehouse-enabled command tree now contributes "warehouse disable": "no" to consentDefaultByLeaf.

Findings outside the diff

  • 🟡 MINOR apps/cli/src/command-internal/hosted-consent/hosted-consent-coverage.unit.test.ts:138 — The consent-default snapshot omits the new warehouse disable command, causing this unit test to fail. The warehouse-enabled command tree now contributes "warehouse disable": "no" to consentDefaultByLeaf.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@bnjjj
bnjjj added this pull request to stack #7672 November 17, 2026 13:51
@bnjjj
bnjjj removed this pull request from stack #7672 November 17, 2026 14:56
@bnjjj
bnjjj merged commit b2f91f2 into feat/generated-warehouse-commands Nov 17, 2026
18 checks passed
@bnjjj
bnjjj deleted the bnjjj/pipe-1447-warehouse-disable branch November 17, 2026 14:57
jgoux added a commit that referenced this pull request Nov 17, 2026
Generate `warehouse status` from `GET
/v2/projects/{ref}/warehouse/status`, preserving readiness,
capabilities, zero-target enablement and unavailable observations
through the shared runtime.

Preserve `warehouse enable --wait` with selection-bound setup polling.
Discover internal polling targets from response links without exposing a
`warehouse setups get` command; status has no wait flags. Retain
teardown waiting.

Keep text output on terminals, raw JSON when piped or requested, and
YAML through `-o yaml`.

Stacked on #7640 (including merged #7660). Depends on
supabase/platform#42039.

Implements PIPE-1445.

---------

Co-authored-by: Julien Goux <hi@jgoux.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant